Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2132359: rbd: remove dummy image workaround #137

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Oct 10, 2022

To address the problem that snapshot schedules are triggered for volumes that are promoted, a dummy image was disabled/enabled for replication. This was done as a workaround, because the promote operation was not triggering the schedules for the image being promoted.

The bugs related to the same have been fixed in RBD mirroring functionality and hence the workaround ceph#2656 can be removed from the code base.

ceph tracker https://tracker.ceph.com/issues/53914

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit 71e5b3f)

cherry-pick of ceph#3413

To address the problem that snapshot
schedules are triggered for volumes
that are promoted, a dummy image was
disabled/enabled for replication.
This was done as a workaround, because the
promote operation was not triggering
the schedules for the image being promoted.

The bugs related to the same have been fixed in
RBD mirroring functionality and hence the
workaround ceph#2656 can be removed from the code base.

ceph tracker https://tracker.ceph.com/issues/53914

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 71e5b3f)
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

@Madhu-1: This pull request references Bugzilla bug 2132359, which is invalid:

  • expected the bug to target the "ODF 4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2132359: rbd: remove dummy image workaround

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Oct 10, 2022
@Rakshith-R
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Oct 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit 053cf97 into red-hat-storage:release-4.12 Oct 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

@Madhu-1: All pull requests linked via external trackers have merged:

Bugzilla bug 2132359 has been moved to the MODIFIED state.

In response to this:

BUG 2132359: rbd: remove dummy image workaround

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rakshith-R
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

@Rakshith-R: Bugzilla bug 2132359 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants